Commit a003ebdc authored by esatakpunar's avatar esatakpunar

code review

parent b0ccde72
......@@ -18,10 +18,8 @@ export default {
"loading",
"dialogHeaders",
"editedItem",
"editedIndex",
"getOptions",
"totalCustomers",
"getSearch",
"getColumn",
]),
indexofColumn() {
......@@ -48,8 +46,6 @@ export default {
"saveCustomer",
"editCustomer",
"setOptions",
"setSearch",
"setColumn",
"searchData",
]),
},
......@@ -101,12 +97,7 @@ export default {
large
color="blue"
class="white--text"
@click="
fetchCustomerData({
searchInput: getSearch,
filterColumn: getColumn,
})
"
@click="fetchCustomerData()"
>
<v-icon>refresh</v-icon>
</v-btn>
......@@ -149,15 +140,7 @@ export default {
<v-btn color="blue darken-1" @click="closeDialog()"
>Cancel</v-btn
>
<v-btn
color="blue darken-1"
@click="
saveCustomer({
searchInput: getSearch,
filterColumn: getColumn,
})
"
>
<v-btn color="blue darken-1" @click="saveCustomer()">
Save</v-btn
>
</template>
......
......@@ -67,6 +67,7 @@ export default {
});
});
},
deleteMultiCustomer({ dispatch }, items) {
const itemList = [];
items.forEach((item) => {
......@@ -95,8 +96,7 @@ export default {
dispatch("closeDialog");
},
editCustomer({ commit, getters }, item) {
commit("setEditedIndex", getters.customerList.indexOf(item));
editCustomer({ commit }, item) {
commit("setEditedItem", Object.assign({}, item));
commit("setDialog", true);
},
......
......@@ -34,9 +34,6 @@ export default {
customerList(state) {
return state.customerList;
},
editedIndex(state) {
return state.editedIndex;
},
editedItem(state) {
return state.editedItem;
},
......
......@@ -2,9 +2,6 @@ export default {
setCustomerList(state, data) {
state.customerList = data;
},
setEditedIndex(state, index) {
state.editedIndex = index;
},
setEditedItem(state, item) {
state.editedItem = item;
},
......
export default () => ({
customerList: [],
editedIndex: -1,
editedItem: {},
dialog: false,
loading: false,
......
......@@ -21,7 +21,6 @@ export default {
"dialog",
"loading",
"editedItem",
"editedIndex",
"getOptions",
"totalProducts",
"getSearch",
......@@ -78,10 +77,7 @@ export default {
]),
},
created() {
this.fetchProductData({
searchInput: this.getSearch,
filterColumn: this.getColumn,
});
this.fetchProductData();
},
};
</script>
......@@ -132,12 +128,7 @@ export default {
large
color="blue"
class="white--text"
@click="
fetchProductData({
searchInput: getSearch,
filterColumn: getColumn,
})
"
@click="fetchProductData()"
>
<v-icon>refresh</v-icon>
</v-btn>
......@@ -180,15 +171,7 @@ export default {
<v-btn color="blue darken-1" @click="closeDialog()"
>Cancel</v-btn
>
<v-btn
color="blue darken-1"
@click="
saveProduct({
searchInput: getSearch,
filterColumn: getColumn,
})
"
>
<v-btn color="blue darken-1" @click="saveProduct()">
Save</v-btn
>
</template>
......
......@@ -76,7 +76,7 @@ export default {
console.log(e);
});
});
this.itemList = [];
console.log();
},
deleteMultiProduct({ dispatch }, items) {
......@@ -87,7 +87,7 @@ export default {
dispatch("deleteProduct", itemList);
},
saveProduct({ getters, dispatch, commit }, data) {
saveProduct({ getters, dispatch, commit }) {
const postConfig = {
method: "post",
url: `http://localhost:3000/products/`,
......@@ -99,17 +99,17 @@ export default {
url: `http://localhost:3000/products/${getters.editedItem.id}`,
data: getters.editedItem,
};
commit("setLoading", true);
axios(!getters.editedItem.id ? postConfig : putConfig).then(() => {
dispatch("fetchProductData", data);
dispatch("fetchProductData");
commit("setLoading", false);
});
dispatch("closeDialog");
},
editProduct({ commit, getters }, item) {
commit("setEditedIndex", getters.productList.indexOf(item));
editProduct({ commit }, item) {
commit("setEditedItem", Object.assign({}, item));
commit("setDialog", true);
},
......
......@@ -44,9 +44,7 @@ export default {
getExpanded(state) {
return state.expanded;
},
editedIndex(state) {
return state.editedIndex;
},
editedItem(state) {
return state.editedItem;
},
......
......@@ -15,9 +15,6 @@ export default {
setLoading(state, value) {
state.loading = value;
},
setEditedIndex(state, index) {
state.editedIndex = index;
},
setEditedItem(state, item) {
state.editedItem = item;
},
......
......@@ -3,7 +3,6 @@ export default () => ({
expanded: [],
filteredProductList: [],
singleExpand: false,
editedIndex: -1,
editedItem: {},
dialog: false,
loading: false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment