Commit a003ebdc authored by esatakpunar's avatar esatakpunar

code review

parent b0ccde72
...@@ -18,10 +18,8 @@ export default { ...@@ -18,10 +18,8 @@ export default {
"loading", "loading",
"dialogHeaders", "dialogHeaders",
"editedItem", "editedItem",
"editedIndex",
"getOptions", "getOptions",
"totalCustomers", "totalCustomers",
"getSearch",
"getColumn", "getColumn",
]), ]),
indexofColumn() { indexofColumn() {
...@@ -48,8 +46,6 @@ export default { ...@@ -48,8 +46,6 @@ export default {
"saveCustomer", "saveCustomer",
"editCustomer", "editCustomer",
"setOptions", "setOptions",
"setSearch",
"setColumn",
"searchData", "searchData",
]), ]),
}, },
...@@ -101,12 +97,7 @@ export default { ...@@ -101,12 +97,7 @@ export default {
large large
color="blue" color="blue"
class="white--text" class="white--text"
@click=" @click="fetchCustomerData()"
fetchCustomerData({
searchInput: getSearch,
filterColumn: getColumn,
})
"
> >
<v-icon>refresh</v-icon> <v-icon>refresh</v-icon>
</v-btn> </v-btn>
...@@ -149,15 +140,7 @@ export default { ...@@ -149,15 +140,7 @@ export default {
<v-btn color="blue darken-1" @click="closeDialog()" <v-btn color="blue darken-1" @click="closeDialog()"
>Cancel</v-btn >Cancel</v-btn
> >
<v-btn <v-btn color="blue darken-1" @click="saveCustomer()">
color="blue darken-1"
@click="
saveCustomer({
searchInput: getSearch,
filterColumn: getColumn,
})
"
>
Save</v-btn Save</v-btn
> >
</template> </template>
......
...@@ -67,6 +67,7 @@ export default { ...@@ -67,6 +67,7 @@ export default {
}); });
}); });
}, },
deleteMultiCustomer({ dispatch }, items) { deleteMultiCustomer({ dispatch }, items) {
const itemList = []; const itemList = [];
items.forEach((item) => { items.forEach((item) => {
...@@ -95,8 +96,7 @@ export default { ...@@ -95,8 +96,7 @@ export default {
dispatch("closeDialog"); dispatch("closeDialog");
}, },
editCustomer({ commit, getters }, item) { editCustomer({ commit }, item) {
commit("setEditedIndex", getters.customerList.indexOf(item));
commit("setEditedItem", Object.assign({}, item)); commit("setEditedItem", Object.assign({}, item));
commit("setDialog", true); commit("setDialog", true);
}, },
......
...@@ -34,9 +34,6 @@ export default { ...@@ -34,9 +34,6 @@ export default {
customerList(state) { customerList(state) {
return state.customerList; return state.customerList;
}, },
editedIndex(state) {
return state.editedIndex;
},
editedItem(state) { editedItem(state) {
return state.editedItem; return state.editedItem;
}, },
......
...@@ -2,9 +2,6 @@ export default { ...@@ -2,9 +2,6 @@ export default {
setCustomerList(state, data) { setCustomerList(state, data) {
state.customerList = data; state.customerList = data;
}, },
setEditedIndex(state, index) {
state.editedIndex = index;
},
setEditedItem(state, item) { setEditedItem(state, item) {
state.editedItem = item; state.editedItem = item;
}, },
......
export default () => ({ export default () => ({
customerList: [], customerList: [],
editedIndex: -1,
editedItem: {}, editedItem: {},
dialog: false, dialog: false,
loading: false, loading: false,
......
...@@ -21,7 +21,6 @@ export default { ...@@ -21,7 +21,6 @@ export default {
"dialog", "dialog",
"loading", "loading",
"editedItem", "editedItem",
"editedIndex",
"getOptions", "getOptions",
"totalProducts", "totalProducts",
"getSearch", "getSearch",
...@@ -78,10 +77,7 @@ export default { ...@@ -78,10 +77,7 @@ export default {
]), ]),
}, },
created() { created() {
this.fetchProductData({ this.fetchProductData();
searchInput: this.getSearch,
filterColumn: this.getColumn,
});
}, },
}; };
</script> </script>
...@@ -132,12 +128,7 @@ export default { ...@@ -132,12 +128,7 @@ export default {
large large
color="blue" color="blue"
class="white--text" class="white--text"
@click=" @click="fetchProductData()"
fetchProductData({
searchInput: getSearch,
filterColumn: getColumn,
})
"
> >
<v-icon>refresh</v-icon> <v-icon>refresh</v-icon>
</v-btn> </v-btn>
...@@ -180,15 +171,7 @@ export default { ...@@ -180,15 +171,7 @@ export default {
<v-btn color="blue darken-1" @click="closeDialog()" <v-btn color="blue darken-1" @click="closeDialog()"
>Cancel</v-btn >Cancel</v-btn
> >
<v-btn <v-btn color="blue darken-1" @click="saveProduct()">
color="blue darken-1"
@click="
saveProduct({
searchInput: getSearch,
filterColumn: getColumn,
})
"
>
Save</v-btn Save</v-btn
> >
</template> </template>
......
...@@ -76,7 +76,7 @@ export default { ...@@ -76,7 +76,7 @@ export default {
console.log(e); console.log(e);
}); });
}); });
this.itemList = []; console.log();
}, },
deleteMultiProduct({ dispatch }, items) { deleteMultiProduct({ dispatch }, items) {
...@@ -87,7 +87,7 @@ export default { ...@@ -87,7 +87,7 @@ export default {
dispatch("deleteProduct", itemList); dispatch("deleteProduct", itemList);
}, },
saveProduct({ getters, dispatch, commit }, data) { saveProduct({ getters, dispatch, commit }) {
const postConfig = { const postConfig = {
method: "post", method: "post",
url: `http://localhost:3000/products/`, url: `http://localhost:3000/products/`,
...@@ -99,17 +99,17 @@ export default { ...@@ -99,17 +99,17 @@ export default {
url: `http://localhost:3000/products/${getters.editedItem.id}`, url: `http://localhost:3000/products/${getters.editedItem.id}`,
data: getters.editedItem, data: getters.editedItem,
}; };
commit("setLoading", true); commit("setLoading", true);
axios(!getters.editedItem.id ? postConfig : putConfig).then(() => { axios(!getters.editedItem.id ? postConfig : putConfig).then(() => {
dispatch("fetchProductData", data); dispatch("fetchProductData");
commit("setLoading", false); commit("setLoading", false);
}); });
dispatch("closeDialog"); dispatch("closeDialog");
}, },
editProduct({ commit, getters }, item) { editProduct({ commit }, item) {
commit("setEditedIndex", getters.productList.indexOf(item));
commit("setEditedItem", Object.assign({}, item)); commit("setEditedItem", Object.assign({}, item));
commit("setDialog", true); commit("setDialog", true);
}, },
......
...@@ -44,9 +44,7 @@ export default { ...@@ -44,9 +44,7 @@ export default {
getExpanded(state) { getExpanded(state) {
return state.expanded; return state.expanded;
}, },
editedIndex(state) {
return state.editedIndex;
},
editedItem(state) { editedItem(state) {
return state.editedItem; return state.editedItem;
}, },
......
...@@ -15,9 +15,6 @@ export default { ...@@ -15,9 +15,6 @@ export default {
setLoading(state, value) { setLoading(state, value) {
state.loading = value; state.loading = value;
}, },
setEditedIndex(state, index) {
state.editedIndex = index;
},
setEditedItem(state, item) { setEditedItem(state, item) {
state.editedItem = item; state.editedItem = item;
}, },
......
...@@ -3,7 +3,6 @@ export default () => ({ ...@@ -3,7 +3,6 @@ export default () => ({
expanded: [], expanded: [],
filteredProductList: [], filteredProductList: [],
singleExpand: false, singleExpand: false,
editedIndex: -1,
editedItem: {}, editedItem: {},
dialog: false, dialog: false,
loading: false, loading: false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment